Added 'Auto' Quality Constant #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you sign a CLA so I can test and merge this? https://developers.google.com/open-source/cla/individual We've documented this process here: https://github.com/youtube/youtube-ios-player-helper/blob/master/CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a constant to account for cases when "Auto" quality is returned from YouTube. I've found this happens mostly when watching YouTube Live Events with the
YTPlayerView. I have modified this PR from #55 to adhere to more of the guidelines for contributing.Tested on iPhones 4s through 6 Plus running iOS 8.1.x. Please let me know if you need any more information. I have signed the individual CLA.