Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] AddressEdit: trim empty value #1150

Merged
merged 63 commits into from May 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
7958bf0
serve
chenjiahan May 13, 2018
31da680
fix demo
chenjiahan May 13, 2018
c204f46
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 14, 2018
4af2462
build
chenjiahan May 14, 2018
6d42cf2
[Improvement] Reorganize document
chenjiahan May 15, 2018
1c7fabc
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 15, 2018
22c2de1
[Improvement] Cell: support number type title & value
chenjiahan May 15, 2018
14cc92e
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 15, 2018
7f23a1e
[bugfix] GoodsAction: info position
chenjiahan May 15, 2018
2e6b33d
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 15, 2018
f9add03
goods action test cases
chenjiahan May 15, 2018
cf316fd
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 15, 2018
fc71a71
[bugfix] test coverage should exclude demo
chenjiahan May 15, 2018
c02bbcd
[Improvement] AddressEdit: style in small screen
chenjiahan May 16, 2018
62fa42c
test
chenjiahan May 16, 2018
7f4b86b
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 16, 2018
a7cafa7
[Improvement] add AddressEdit test cases
chenjiahan May 16, 2018
ff0a067
fix transition
chenjiahan May 17, 2018
ebc8677
[bugfix] Icon template
chenjiahan May 17, 2018
ad53b31
merge
chenjiahan May 17, 2018
37305aa
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 17, 2018
599d6a8
[Improvement] Field: add left-icon prop
chenjiahan May 17, 2018
de39fb2
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 17, 2018
bdc420a
[Improvement] Progress: support gradient color
chenjiahan May 18, 2018
f9b1d5b
fix
chenjiahan May 18, 2018
90d1d98
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 18, 2018
a0b4b86
[Improvement] Rate: add change event
chenjiahan May 18, 2018
75272e8
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 19, 2018
daec732
[Improvement] Rate: add test cases
chenjiahan May 19, 2018
cb5e14a
[Improvement] Toast: add test cases
chenjiahan May 19, 2018
18ebce0
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 19, 2018
7b22a30
[Doc] add gzip size
chenjiahan May 19, 2018
e3c8089
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 19, 2018
131140c
[Build] use es entry file
chenjiahan May 19, 2018
85a6888
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 19, 2018
423e6e0
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 19, 2018
5661e0b
[Improvement] optimize isDef
chenjiahan May 19, 2018
c7d9a11
[Improvement] reduce scroll utils
chenjiahan May 19, 2018
ac06db7
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 19, 2018
ecae88b
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 19, 2018
344f358
[Improvement] optimize babel plugin
chenjiahan May 20, 2018
34b439a
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 21, 2018
fb8340e
[Improvement] TreeSelect: support string type id
chenjiahan May 21, 2018
8da881a
[Improvement] NumberKeyboard: add close event
chenjiahan May 21, 2018
497d86a
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 21, 2018
a3f89e6
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 22, 2018
2244fcd
[Improvement] Progress: pivot shouldn't cross border
chenjiahan May 22, 2018
47ae0eb
[Improvement] Popup: support lazy render
chenjiahan May 23, 2018
feb6d0d
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 23, 2018
42b6c42
fix
chenjiahan May 23, 2018
6a4a4ef
[Doc] fix field wrong spelling
chenjiahan May 23, 2018
b78dfe4
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 23, 2018
1b96e51
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 23, 2018
6a36084
[Improvement] Picker: update unselected option color
chenjiahan May 23, 2018
1c92ba3
picker test
chenjiahan May 23, 2018
946966b
[bugfix] Field: normalize input margin in safari
chenjiahan May 24, 2018
ed40489
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 24, 2018
cc0998f
[Improvement] Dialog: prevent button text select
chenjiahan May 24, 2018
8962656
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 24, 2018
728960b
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 24, 2018
5de7883
update dependencies
chenjiahan May 24, 2018
d2eea0a
[Improvement] AddressEdit: trim empty value
chenjiahan May 24, 2018
13dc336
Merge remote-tracking branch 'main/dev' into dev
chenjiahan May 24, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/address-edit/index.vue
Expand Up @@ -251,7 +251,7 @@ export default create({
},

getErrorMessageByKey(key) {
const value = this.data[key];
const value = this.data[key].trim();
const { $t } = this;

switch (key) {
Expand Down
2 changes: 1 addition & 1 deletion packages/contact-edit/index.vue
Expand Up @@ -81,7 +81,7 @@ export default create({
},

getErrorMessageByKey(key) {
const value = this.data[key];
const value = this.data[key].trim();
switch (key) {
case 'name':
return value ? value.length <= 15 ? '' : this.$t('nameOverlimit') : this.$t('nameEmpty');
Expand Down