Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ConfigProvider): supplement the type declaration of ConfigProviderThemeVars #12264

Merged
merged 3 commits into from
Sep 8, 2023
Merged

feat(ConfigProvider): supplement the type declaration of ConfigProviderThemeVars #12264

merged 3 commits into from
Sep 8, 2023

Conversation

xieyezi
Copy link
Contributor

@xieyezi xieyezi commented Sep 8, 2023

  • supplement the type declaration of ConfigProviderThemeVars.
  • (补充 ConfigProvider 组件的 ConfigProviderThemeVars 类型声明)

@xieyezi xieyezi changed the title feat(ConfigProvide): supplement the type declaration of ConfigProviderThemeVars feat(ConfigProvider): supplement the type declaration of ConfigProviderThemeVars Sep 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023 •
edited

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@chenjiahan
Copy link
Member

chenjiahan commented Sep 8, 2023 •
edited

变量统一用驼峰格式比较好，有另一个 PR：#12265

@xieyezi
Copy link
Contributor Author

xieyezi commented Sep 8, 2023

@chenjiahan 更新了一下，你看下合并哪个PR吧。希望是我的，哈哈

@chenjiahan
Copy link
Member

嗯嗯，合并这个 PR 哈，时间早一些😄

@chenjiahan chenjiahan merged commit 7c7202d into youzan:main Sep 8, 2023
3 checks passed
This was referenced Sep 8, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
change: feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xieyezi @codecov-commenter @chenjiahan