feat(Calendar): add click-disabled-date event #12274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
chenjiahan
reviewed
Sep 11, 2023
| @@ -116,6 +116,7 @@ export default defineComponent({ | |||
| 'overRange', | |||
| 'update:show', | |||
| 'clickSubtitle', | |||
| 'click-disabled-date', | |||
chenjiahan
reviewed
Sep 11, 2023
| @@ -64,6 +64,8 @@ export default defineComponent({ | |||
| const onClick = () => { | |||
| if (props.item.type !== 'disabled') { | |||
| emit('click', props.item); | |||
| } else { | |||
| emit('click-disabled-date', props.item); | |||
|
好的，明天补充，
发自我的iPhone
…------------------ Original ------------------
From: neverland ***@***.***>
Date: Mon,Sep 11,2023 10:19 PM
To: youzan/vant ***@***.***>
Cc: luopei ***@***.***>, Author ***@***.***>
Subject: Re: [youzan/vant] feat(Calendar): add click-disabled-date event (PR#12274)
@chenjiahan commented on this pull request.
In packages/vant/src/calendar/CalendarDay.tsx:
> @@ -64,6 +64,8 @@ export default defineComponent({ const onClick = () => { if (props.item.type !== 'disabled') { emit('click', props.item); + } else { + emit('click-disabled-date', props.item);
能否补充一个单元测试~
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
好的，
发自我的iPhone
…------------------ Original ------------------
From: neverland ***@***.***>
Date: Mon,Sep 11,2023 10:18 PM
To: youzan/vant ***@***.***>
Cc: luopei ***@***.***>, Author ***@***.***>
Subject: Re: [youzan/vant] feat(Calendar): add click-disabled-date event (PR#12274)
@chenjiahan commented on this pull request.
In packages/vant/src/calendar/Calendar.tsx:
> @@ -116,6 +116,7 @@ export default defineComponent({ 'overRange', 'update:show', 'clickSubtitle', + 'click-disabled-date',
eventName 统一使用驼峰格式哈
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
单元测试已经补充，
发自我的iPhone
…------------------ Original ------------------
From: neverland ***@***.***>
Date: Mon,Sep 11,2023 10:19 PM
To: youzan/vant ***@***.***>
Cc: luopei ***@***.***>, Author ***@***.***>
Subject: Re: [youzan/vant] feat(Calendar): add click-disabled-date event (PR#12274)
@chenjiahan commented on this pull request.
In packages/vant/src/calendar/CalendarDay.tsx:
> @@ -64,6 +64,8 @@ export default defineComponent({ const onClick = () => { if (props.item.type !== 'disabled') { emit('click', props.item); + } else { + emit('click-disabled-date', props.item);
能否补充一个单元测试~
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
chenjiahan
approved these changes
Sep 13, 2023
|
👍🏻👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解决问题: 日历组件新增 click-disabled-date 事件
相关issue: #12247