Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Popup): fix failed to inherit scopedId #12327

Merged
merged 1 commit into from Sep 29, 2023
Merged

fix(Popup): fix failed to inherit scopedId #12327

merged 1 commit into from Sep 29, 2023

Conversation

chenjiahan
Copy link
Member

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/vant/src/popup/Popup.tsx 90.69% <ø> (ø)
packages/vant/src/composables/use-scope-id.ts 33.33% <33.33%> (ø)

📢 Thoughts on this report? Let us know!.

@chenjiahan chenjiahan merged commit 24e9176 into main Sep 29, 2023
7 checks passed
@chenjiahan chenjiahan deleted the popup_scoped_id_0929 branch September 29, 2023 13:09
@chenjiahan chenjiahan mentioned this pull request Oct 6, 2023
Merged
CatsAndMice pushed a commit to CatsAndMice/vant that referenced this pull request Apr 8, 2024
@chenjiahan @CatsAndMice
fix(Popup): fix failed to inherit scopedId (youzan#12327)
31c90c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] 在van-popup上使用scoped的class，不生效
2 participants
@chenjiahan @codecov-commenter