-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(canendar): subtitle supports reactive #12425
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
@@ -87,7 +88,7 @@ export default defineComponent({ | |||
|
|||
const shouldRender = computed(() => visible.value || !props.lazyRender); | |||
|
|||
const getTitle = () => title.value; | |||
const getTitle = () => toRef(title, 'value'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change? The title
param of month-show
event is changed.
The previous type was string, but now the type is Ref<string>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change. the title
should change responsively with locale
changes.
The title
type didn't change, that was my mistake.
🤯 I did a lot of breaking change. For |
We can not introduce any breaking changes in a minor or patch release, so we can only make forward-compatible changes. |
Thanks to your suggestion, I removed breaking change. |
Thanks! |
fix: subTitle supports responsive switching when international language changes
close #12423