Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextEllipsis): add action slot #12560

Merged

Conversation

nemo-shen
Copy link
Contributor

@nemo-shen nemo-shen commented Jan 9, 2024

issue: #12470
related PR: #12487

CleanShot 2024-01-11 at 19 42 36@2x CleanShot 2024-01-11 at 19 42 45@2x

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cb8f32) 89.89% compared to head (8468d22) 89.91%.

❗ Current head 8468d22 differs from pull request most recent head f386512. Consider uploading reports for the commit f386512 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12560      +/-   ##
==========================================
+ Coverage   89.89%   89.91%   +0.01%     
==========================================
  Files         257      257              
  Lines        6821     6823       +2     
  Branches     1653     1654       +1     
==========================================
+ Hits         6132     6135       +3     
  Misses        365      365              
+ Partials      324      323       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nemo-shen nemo-shen changed the title feat(TextEllipsis): add slot expand-text and collapse-text feat(TextEllipsis): add action slot Jan 11, 2024
@chenjiahan chenjiahan enabled auto-merge (squash) January 11, 2024 14:20
@chenjiahan
Copy link
Member

LGTM 👍🏻

@chenjiahan chenjiahan merged commit 3f6a00a into youzan:main Jan 11, 2024
3 checks passed
CatsAndMice pushed a commit to CatsAndMice/vant that referenced this pull request Apr 8, 2024
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants