feat(ImagePreview): add close-on-click-image prop #12566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12566 +/- ##
=======================================
Coverage 89.91% 89.92%
=======================================
Files 257 257
Lines 6823 6827 +4
Branches 1654 1655 +1
=======================================
+ Hits 6135 6139 +4
Misses 365 365
Partials 323 323 ☔ View full report in Codecov by Sentry. |
chenjiahan
reviewed
Jan 13, 2024
| @@ -251,8 +252,12 @@ export default defineComponent({ | |||
| }; | |||
|
|
|||
| const checkClose = (event: TouchEvent) => { | |||
| const isClickOverlay = event.target === swipeItem.value?.$el; | |||
| const swipeItemEl: HTMLElement = swipeItem.value?.$el; | |||
| const imageEl = swipeItemEl.firstElementChild; | |||
There was a problem hiding this comment.
When using slots, it's also possible that the image element is not the first element, should we consider that case
There was a problem hiding this comment.
Fortunately, the parent element of the image slot is always fixed, so we don't have to consider this situation.
<div class={bem('image-wrap')}>
{slots.image({ src: props.src })}
</div>
chenjiahan
approved these changes
Jan 13, 2024
|
看文档是v4.83发布，看最新版本只到了v4.82，v4.83预计什么时候发布呀？急需要此属性~~~谢谢谢谢 @chenjiahan |
|
今天或明天发布哈 |
CatsAndMice
pushed a commit
to CatsAndMice/vant
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #12448
When the elements in the slot have their own click interaction logic, such as video elements, the click should not close the preview.