Revert "fix(DropdownMenu): fix recursive update when passing object literal to title-class (#12614)" #12617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iteral to title-class (youzan#12614)" This reverts commit a5a9a6c.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12617 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 257 257
Lines 6830 6830
Branches 1657 1657
=======================================
Hits 6137 6137
Misses 369 369
Partials 324 324 ☔ View full report in Codecov by Sentry. |
chenjiahan
approved these changes
Feb 4, 2024
|
🫡 |
CatsAndMice
pushed a commit
to CatsAndMice/vant
that referenced
this pull request
Apr 8, 2024
…iteral to title-class (youzan#12614)" (youzan#12617)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert #12614
之前的实现方式还是有 case 没考虑到，先 revert 了。