Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for params related to Picker events #12619

Merged
merged 1 commit into from
Feb 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/vant/src/date-picker/README.md
Expand Up @@ -188,9 +188,9 @@ export default {

| Event | Description | Arguments |
| --- | --- | --- |
| confirm | Emitted when the confirm button is clicked | _{ selectedValues, selectedOptions }_ |
| cancel | Emitted when the cancel button is clicked | _{ selectedValues, selectedOptions }_ |
| change | Emitted when current option is changed | _{ selectedValues, selectedOptions, columnIndex }_ |
| confirm | Emitted when the confirm button is clicked | _{ selectedValues, selectedOptions, selectedIndexes }_ |
| cancel | Emitted when the cancel button is clicked | _{ selectedValues, selectedOptions, selectedIndexes }_ |
| change | Emitted when current option is changed | _{ selectedValues, selectedOptions, selectedIndexes, columnIndex }_ |

### Slots

Expand Down
6 changes: 3 additions & 3 deletions packages/vant/src/date-picker/README.zh-CN.md
Expand Up @@ -194,9 +194,9 @@ export default {

| 事件名 | 说明 | 回调参数 |
| --- | --- | --- |
| confirm | 点击完成按钮时触发 | _{ selectedValues, selectedOptions }_ |
| cancel | 点击取消按钮时触发 | _{ selectedValues, selectedOptions }_ |
| change | 选项改变时触发 | _{ selectedValues, selectedOptions, columnIndex }_ |
| confirm | 点击完成按钮时触发 | _{ selectedValues, selectedOptions, selectedIndexes }_ |
| cancel | 点击取消按钮时触发 | _{ selectedValues, selectedOptions, selectedIndexes }_ |
| change | 选项改变时触发 | _{ selectedValues, selectedOptions, selectedIndexes, columnIndex }_ |

### Slots

Expand Down
6 changes: 3 additions & 3 deletions packages/vant/src/time-picker/README.md
Expand Up @@ -267,9 +267,9 @@ export default {

| Event | Description | Arguments |
| --- | --- | --- |
| confirm | Emitted when the confirm button is clicked | _{ selectedValues, selectedOptions }_ |
| cancel | Emitted when the cancel button is clicked | _{ selectedValues, selectedOptions }_ |
| change | Emitted when current option is changed | _{ selectedValues, selectedOptions, columnIndex }_ |
| confirm | Emitted when the confirm button is clicked | _{ selectedValues, selectedOptions, selectedIndexes }_ |
| cancel | Emitted when the cancel button is clicked | _{ selectedValues, selectedOptions, selectedIndexes }_ |
| change | Emitted when current option is changed | _{ selectedValues, selectedOptions, selectedIndexes, columnIndex }_ |

### Slots

Expand Down
6 changes: 3 additions & 3 deletions packages/vant/src/time-picker/README.zh-CN.md
Expand Up @@ -268,9 +268,9 @@ export default {

| 事件名 | 说明 | 回调参数 |
| --- | --- | --- |
| confirm | 点击完成按钮时触发 | _{ selectedValues, selectedOptions }_ |
| cancel | 点击取消按钮时触发 | _{ selectedValues, selectedOptions }_ |
| change | 选项改变时触发 | _{ selectedValues, selectedOptions, columnIndex }_ |
| confirm | 点击完成按钮时触发 | _{ selectedValues, selectedOptions, selectedIndexes }_ |
| cancel | 点击取消按钮时触发 | _{ selectedValues, selectedOptions, selectedIndexes }_ |
| change | 选项改变时触发 | _{ selectedValues, selectedOptions, selectedIndexes, columnIndex }_ |

### Slots

Expand Down
6 changes: 3 additions & 3 deletions packages/vant/src/time-picker/test/index.spec.tsx
Expand Up @@ -122,18 +122,18 @@ test('should filter options when using filter prop to filter a time range', asyn
});

const picker = wrapper.findComponent(Picker);
let columns = picker.props('columns');
let columns = picker.props('columns')!;
expect(columns[0].length).toEqual(11);
expect(columns[1].length).toEqual(20);
expect(columns[0][0].value).toEqual('08');
expect(columns[1][0].value).toEqual('40');

await wrapper.setProps({ modelValue: ['09', '00'] });
columns = picker.props('columns');
columns = picker.props('columns')!;
expect(columns[1].length).toEqual(60);

await wrapper.setProps({ modelValue: ['18', '00'] });
columns = picker.props('columns');
columns = picker.props('columns')!;
expect(columns[1].length).toEqual(21);
expect(columns[1][20].value).toEqual('20');
});
Expand Down