Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Image): add crossorigin & referrerpolicy #12641

Merged
merged 2 commits into from Feb 21, 2024
Merged

Conversation

Jungzl
Copy link
Contributor

@Jungzl Jungzl commented Feb 21, 2024

fix: #12634

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41bbe5b) 89.80% compared to head (291334b) 89.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12641      +/-   ##
==========================================
+ Coverage   89.80%   89.89%   +0.08%     
==========================================
  Files         257      257              
  Lines        6830     6830              
  Branches     1657     1657              
==========================================
+ Hits         6134     6140       +6     
+ Misses        373      367       -6     
  Partials      323      323              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chouchouji
Copy link
Contributor

这两个属性对于ios的兼容性不匹配吧

image

image

@Jungzl
Copy link
Contributor Author

Jungzl commented Feb 21, 2024

这两个属性对于ios的兼容性不匹配吧

image

image

雀食,不过加了的话可以让部分使用者获益,兼容性就没辙了😟

@chenjiahan
Copy link
Member

这类原生属性可以接受超出 Vant 默认的兼容性范围,使用者需要自行关注下原生属性的兼容性。

比如 Uploader 的 multiple、capture 属性类似,也存在部分浏览器不支持的情况。

@chenjiahan chenjiahan merged commit 09941e5 into youzan:main Feb 21, 2024
3 checks passed
@Jungzl Jungzl deleted the feat-image branch February 21, 2024 13:39
CatsAndMice pushed a commit to CatsAndMice/vant that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] image组件新增referrerPolicy属性
4 participants