Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PickerGroup): rendering correctly when using v-for #12732

Merged
merged 1 commit into from Mar 31, 2024

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Mar 26, 2024

fix #12728

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.75%. Comparing base (f578ac2) to head (714d03d).
Report is 2 commits behind head on main.

Files Patch % Lines
packages/vant/src/picker-group/PickerGroup.tsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12732      +/-   ##
==========================================
- Coverage   89.75%   89.75%   -0.01%     
==========================================
  Files         257      257              
  Lines        6835     6842       +7     
  Branches     1660     1662       +2     
==========================================
+ Hits         6135     6141       +6     
- Misses        373      374       +1     
  Partials      327      327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@chenjiahan chenjiahan merged commit b1e746f into youzan:main Mar 31, 2024
4 checks passed
bluesky335 pushed a commit to bluesky335/vant that referenced this pull request Apr 1, 2024
CatsAndMice pushed a commit to CatsAndMice/vant that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] PickerGroup子组件渲染bug
3 participants