Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new feature] Popup: add open/close event #2649

Merged
merged 1 commit into from Jan 30, 2019
Merged

[new feature] Popup: add open/close event #2649

merged 1 commit into from Jan 30, 2019

Conversation

chenjiahan
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2649 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2649      +/-   ##
==========================================
+ Coverage   87.98%   87.99%   +0.01%     
==========================================
  Files         104      104              
  Lines        1956     1958       +2     
  Branches       52       52              
==========================================
+ Hits         1721     1723       +2     
  Misses        218      218              
  Partials       17       17
Impacted Files Coverage Δ
packages/mixins/popup/index.js 98.11% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9dbf1...43e8d42. Read the comment docs.

@chenjiahan chenjiahan merged commit 466bb3c into youzan:dev Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants