Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Popup: get-container error when destoryed #2679

Merged
merged 2 commits into from Feb 3, 2019
Merged

[bugfix] Popup: get-container error when destoryed #2679

merged 2 commits into from Feb 3, 2019

Conversation

chenjiahan
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #2679 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2679   +/-   ##
=======================================
  Coverage   89.24%   89.24%           
=======================================
  Files         102      102           
  Lines        1972     1972           
=======================================
  Hits         1760     1760           
  Misses        212      212
Impacted Files Coverage Δ
packages/mixins/popup/index.js 98.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583f89f...88c59b4. Read the comment docs.

@chenjiahan chenjiahan merged commit d20b7fd into youzan:dev Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants