[new feature] Coupon: add valueDesc、unitDesc prop #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjiahan
reviewed
Feb 11, 2019
chenjiahan
reviewed
Feb 11, 2019
packages/coupon/index.js
Outdated
| return `${coupon.valueDesc}<span>${coupon.unitDesc}</span>`; | ||
| } | ||
| return coupon.denominations | ||
| ? `${formatAmount(coupon.denominations)}<span>${this.currency}</span>` |
There was a problem hiding this comment.
修改 currency 位置会导致 breaking change
There was a problem hiding this comment.
那这里处理成未传入 valueDesc 和 unitDesc 时维持原样吧？
还是¥1.00，新的会是1.00元
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes you made in this pull request: