Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new feature] DropdownMenu: add direction prop #3490

Merged
merged 4 commits into from Jun 13, 2019
Merged

[new feature] DropdownMenu: add direction prop #3490

merged 4 commits into from Jun 13, 2019

Conversation

chenjiahan
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #3490 into dev will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #3490      +/-   ##
=========================================
+ Coverage   92.2%   92.53%   +0.32%     
=========================================
  Files        117      117              
  Lines       2578     2584       +6     
  Branches     223      223              
=========================================
+ Hits        2377     2391      +14     
+ Misses       177      169       -8     
  Partials      24       24
Impacted Files Coverage Δ
packages/dropdown-item/index.js 89.65% <100%> (+13.65%) ⬆️
packages/dropdown-menu/index.js 100% <100%> (+17.64%) ⬆️
packages/mixins/click-outside.js 83.33% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156ac95...fb18b7a. Read the comment docs.

@chenjiahan chenjiahan merged commit 6b7307a into youzan:dev Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants