Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Sku: optimize DOM #704

Merged
merged 181 commits into from Mar 16, 2018
Merged

[Improvement] Sku: optimize DOM #704

merged 181 commits into from Mar 16, 2018

Conversation

chenjiahan
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 16, 2018

Codecov Report

Merging #704 into dev will increase coverage by 0.23%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #704      +/-   ##
==========================================
+ Coverage   91.57%   91.81%   +0.23%     
==========================================
  Files         103      103              
  Lines        2065     2052      -13     
  Branches      318      314       -4     
==========================================
- Hits         1891     1884       -7     
+ Misses         77       74       -3     
+ Partials       97       94       -3
Impacted Files Coverage Δ
packages/sku/components/SkuMessages.vue 87.09% <ø> (-0.21%) ⬇️
packages/address-list/index.vue 80% <ø> (ø) ⬆️
packages/sku/components/SkuStepper.vue 85.29% <ø> (+0.44%) ⬆️
packages/contact-list/index.vue 80% <ø> (ø) ⬆️
packages/utils/node.js 0% <ø> (ø) ⬆️
packages/address-edit/index.vue 98.79% <100%> (ø) ⬆️
packages/cell-group/index.vue 50% <100%> (ø) ⬆️
packages/cell/index.vue 83.33% <100%> (ø) ⬆️
packages/utils/create.js 100% <100%> (ø) ⬆️
packages/sku/components/SkuRowItem.vue 84.61% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd72e5...f44dfae. Read the comment docs.

@chenjiahan chenjiahan merged commit 4c195fd into youzan:dev Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants