Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy lifecycles #1060

Closed
23 tasks done
intellild opened this issue Apr 29, 2019 · 10 comments · Fixed by #1074
Closed
23 tasks done

Legacy lifecycles #1060

intellild opened this issue Apr 29, 2019 · 10 comments · Fixed by #1074
Labels
help wanted

Comments

@intellild
Copy link
Contributor

intellild commented Apr 29, 2019 •
edited by ronghang
Loading

Here is list of legacy lifecycles used in zent except Grid, Table, Select, Popover.
This is tracking issue for removing them.

Contribution guide:

  1. Open a pull request
  2. Comment here to let others know you are working on it.

componentWillReceiveProps

  • tree/Tree.tsx
  • clamp-lines/ClampLines.tsx
  • swiper/Swiper.tsx
  • cascader/Cascader.tsx
  • slider/Slider.tsx
  • slider/Points.tsx
  • menu/SubMenu.tsx
  • colorpicker/SketchFields.tsx
  • datetimepicker/MonthPicker.tsx
  • datetimepicker/QuarterPicker.tsx
  • datetimepicker/WeekPicker.tsx
  • datetimepicker/TimePicker.tsx
  • datetimepicker/DatePicker.tsx
  • datetimepicker/YearPicker.tsx
  • pagination/impl/BasePagination.ts
  • pagination/components/PageSizeChanger.tsx
  • utils/component/LazyMount.tsx
  • colorpicker/common/ColorWrap.tsx
  • colorpicker/common/EditableInput.tsx
  • upload/components/UploadPopup.tsx
  • pagination/components/jumper/MiniPageJumper.tsx
  • pagination/components/button/ArrowButton.tsx

componentWillMount

  • cascader/Cascader.tsx
@cpylua
Copy link
Contributor

cpylua commented May 6, 2019 •
edited
Loading

pagination 的我来改。

#1083

@makebanana
Copy link
Collaborator

tree me

@wulv
Copy link
Contributor

wulv commented May 6, 2019

  • cascader
  • slider
  • upload

@xingzhiFun
Copy link
Collaborator

  • menu
  • clamp-lines

@chenjiahan
Copy link
Member

chenjiahan commented May 6, 2019 •
edited
Loading

Exciting

@AsukaSong
Copy link
Contributor

i'll take care of all datetimepicker

  • datetimepicker/MonthPicker.tsx
  • datetimepicker/QuarterPicker.tsx
  • datetimepicker/WeekPicker.tsx
  • datetimepicker/TimePicker.tsx
  • datetimepicker/DatePicker.tsx
  • datetimepicker/YearPicker.tsx

@AsukaSong AsukaSong mentioned this issue May 7, 2019
Merged
@wulv wulv mentioned this issue May 9, 2019
Merged
@RichardSleet
Copy link
Contributor

  • slider

  • colorpicker

  • utils

@liaoyu
Copy link
Contributor

liaoyu commented May 13, 2019

  • cascader

@xingzhiFun xingzhiFun mentioned this issue May 13, 2019
Merged
@intellild
Copy link
Contributor Author

  • AnimationHeight

@liaoyu liaoyu mentioned this issue May 14, 2019
Merged
@cpylua cpylua reopened this Jul 26, 2019
@ronghang
Copy link
Contributor

colorpicker

@cpylua cpylua closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] Cascader: 重构 componentWillReceiveProps 及移除 componentWillMount youzan/zent
10 participants
@cpylua @liaoyu @chenjiahan @intellild @wulv @xingzhiFun @ronghang @makebanana @RichardSleet @AsukaSong