Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade React18 #1991

Merged
merged 24 commits into from
Jan 19, 2023
Merged

upgrade React18 #1991

merged 24 commits into from
Jan 19, 2023

Conversation

yvan0423
Copy link
Contributor

Changes you made in this pull request:

Copy link
Collaborator

@cpylua cpylua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主要看下为啥 props 有两种写法

packages/zent/src/block-header/BlockHeader.tsx Outdated Show resolved Hide resolved
packages/zent/src/breadcrumb/Item.tsx Outdated Show resolved Hide resolved
packages/zent/src/cascader/trigger/SingleTrigger.tsx Outdated Show resolved Hide resolved
packages/zent/src/cascader/trigger/TagsTrigger.tsx Outdated Show resolved Hide resolved
packages/zent/src/form/form-components/InputField.tsx Outdated Show resolved Hide resolved
packages/zent/src/form/form-components/SwitchField.tsx Outdated Show resolved Hide resolved
packages/zent/src/form/form-components/TimePickerField.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@cpylua cpylua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

剩下没有resolve的问题再看下

Copy link
Collaborator

@cpylua cpylua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

这个看下。

SplitButton 那个改回去吧,要写对改动有点大。

packages/zent/package.json Outdated Show resolved Hide resolved
packages/zent/package.json Outdated Show resolved Hide resolved
@cpylua cpylua merged commit 0859c2c into youzan:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants