New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply gcc -Wpedantic linting #19
Conversation
Hey, thanks for the PR. The lingering issues with arm and x86 due to lack of testing motivated me to finally set up some CI on this project. However, at least x86 seems to be working ok? What sort of issues did you run into on those, and were you running them on their native archs? |
nice
I actually couldn't get this to run with clang or gcc. When I'm home, ill have to check.
I wasn't running them on their native arch (so i didn't expect arm to work), but i did expect the x86 to compile and run, as the documentation makes it seem like that's a supported use case. |
Sounds good. Yes, x86 is supported in that context, however it depends on libedit-dev:i386 packages to exist, which Im guessing was causing problems. Either way, that's unrelated to the this PR, but please do let me know if x86 is broken for some other reason. |
ah, yes, that was most likely it, libedit was x86-64, that makes sense. I'll let you know if i find x86 to be broken for other reasons. Anyway, cool little project you got here, and a very nice interactive experience :) |
Also, I confirmed that it does work for x86 as well:
|
Awesome, thanks for checking that out and also for working on the nixos packaging, kinda cool to see it being packaged up for easy install :) |
yea, one of the things I like about nix is that it makes is very easy to bundle runtime and buildtime dependencies without interfering with your system install. so if someone wants to test out rappel:
it will download (or build) all the needed dependencies for the package, and the plus it good at only exposing what you really want, for example I don't have nasm installed:
Since the nasm utility is wrapped around your binary, it gets called with nasm on it's PATH, but my environment doesn't need it.
.rappel-wrapped is your actual binary
|
That's pretty slick. I don't actually use linux too much these days, but if I started again I might give nixos a shot 👍 |
I know you mention using clang to compile the project, but this PR will allow for compilation with gcc7 without any warnings.
Also, removed some extra whitespace.
Note: I only tested the AMD64 version. (i couldn't get arm or x86 to work, even on master)
Output before changes
Output after changes