Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rappel: init at unstable-2019-07-08 #68282

Merged
merged 2 commits into from
Sep 8, 2019
Merged

rappel: init at unstable-2019-07-08 #68282

merged 2 commits into from
Sep 8, 2019

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

rappel is an assembly REPL.
Useful to help learning assembly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Pamplemousse Pamplemousse changed the title Rappel rappel: init Sep 7, 2019
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 7, 2019
ivan
ivan suggested changes Sep 7, 2019
View reviewed changes
pkgs/development/misc/rappel/default.nix Outdated Show resolved Hide resolved
pkgs/development/misc/rappel/default.nix Outdated Show resolved Hide resolved
ivan
ivan suggested changes Sep 7, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should include the version, e.g. "rappel: init at unstable-2019-07-08"

jtojnar
jtojnar requested changes Sep 7, 2019
View reviewed changes
pkgs/development/misc/rappel/default.nix Outdated Show resolved Hide resolved
pkgs/development/misc/rappel/default.nix Show resolved Hide resolved
@Pamplemousse
Copy link
Member Author

Thank you all for your feedback!

@ivan
Copy link
Member

ivan commented Sep 8, 2019

@GrahamcOfBorg build rappel

@worldofpeace worldofpeace changed the title rappel: init rappel: init at unstable-2019-07-08 Sep 8, 2019
@worldofpeace worldofpeace merged commit ec27f6f into NixOS:master Sep 8, 2019
@Pamplemousse Pamplemousse deleted the rappel branch August 11, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@marsam marsam marsam approved these changes

@ivan ivan ivan approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pamplemousse @ivan @marsam @jtojnar @jonringer @worldofpeace