Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements and multithreading / start stop issues fixed #13

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

srmncnk
Copy link
Collaborator

@srmncnk srmncnk commented Oct 3, 2022

This PR address general improvements and multithreading / start stop issues.

Please review and consider merging.

@srmncnk
Copy link
Collaborator Author

srmncnk commented Oct 10, 2022

@ysak-y Can you please take a look at this and consider merging? Many thanks.

@ysak-y
Copy link
Owner

ysak-y commented Oct 10, 2022

Hi @srmanc , thank you for your PR. I'll check until next Monday.

@ysak-y
Copy link
Owner

ysak-y commented Oct 16, 2022

Checked. LGTM

@ysak-y ysak-y merged commit 84ddbb4 into ysak-y:master Oct 16, 2022
@ysak-y
Copy link
Owner

ysak-y commented Oct 16, 2022

Now I published new version v1.1.1 with your implementation. Thanks @srmanc !!
https://github.com/ysak-y/flutter_audio_capture/blob/master/CHANGELOG.md#111

@kijka
Copy link

kijka commented Nov 29, 2022

@srmanc looks like there is an iOS issue #16
Do you have any ideas about what could be wrong?

@kijka
Copy link

kijka commented Nov 30, 2022

@srmanc @ysak-y I've added a project to test and video demo of the bug to the #16

@ysak-y
Copy link
Owner

ysak-y commented Dec 3, 2022

@srmanc What do you think about #16 ? As @vladsonkin reports, it seems be disabled after some time, and I guess it would be because of multithreading.

@srmncnk
Copy link
Collaborator Author

srmncnk commented Dec 3, 2022

@vladsonkin @ysak-y Thanks for the reproducible example, I'll take a look this weekend.

@kijka
Copy link

kijka commented Dec 14, 2022

@srmanc Thanks! Any ideas on how to fix it? Maybe it's the init block in SwiftFlutterAudioCapturePlugin?

@srmncnk
Copy link
Collaborator Author

srmncnk commented Dec 20, 2022

Prepared a PR, please test it: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants