Disabled waiting for first data on iOS by default and timeout parameter added #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merged only after @vladsonkin has confirmed it works for him. |
This was referenced Dec 20, 2022
|
@srmanc it works! Thanks for the Christmas present :] If the "waiting for the first data" feature doesn't work reliably on iOS, then maybe we can fully delete it? Otherwise, functionality could differ per platform. Or maybe add a comment that this flag on iOS can be buggy. @ysak-y could you create a new release, please? |
kijka
approved these changes
Dec 20, 2022
|
Yeah, sure, comment added. 7bea0c8 |
|
@ysak-y If you want me to do it, i need write access to this repository. Happy to do it though. |
|
@srmanc Hi, I've invited you as the collaborator. Please approve if you want, you'll be permitted to merge it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue with latest versions not working on iOS: #16
By default, iOS no longer waits for first data to arrive. Instead a parameter is added for this behaviour. A timeout parameter is also added in case we have to wait longer on iOS for the data to arrive.