Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dry-run mode #23

Merged
merged 3 commits into from
Feb 25, 2023
Merged

dry-run mode #23

merged 3 commits into from
Feb 25, 2023

Conversation

yseto
Copy link
Owner

@yseto yseto commented Feb 25, 2023

closes #15

  • dry-run の実装です。
  • YAML上で設定の可否が可能です。
    • 引数での指定については後続のPRで、設定ファイルの指定と共に実装します。
  • mackerelのクライアント初期化ロジックを移動しました。
  • dry-run で動作させる場合、mackerelのクライアントを初期化しないことで、ジョブキューでの挙動を分けています。
  • どういうモードで実行されているか、起動時にメッセージを追加しています。

@yseto yseto requested a review from kmuto February 25, 2023 13:23
kmuto
kmuto reviewed Feb 25, 2023
View reviewed changes
trap.go Outdated Show resolved Hide resolved
kmuto
kmuto approved these changes Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@kmuto kmuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fail safe入れときます

@yseto @kmuto
Update trap.go
c36d4bc 
Co-authored-by: Kenshi Muto <kmuto@kmuto.jp>
@yseto yseto merged commit c9d253b into main Feb 25, 2023
@yseto yseto deleted the dryrun branch February 25, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmuto kmuto kmuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dry-runモード
2 participants
@yseto @kmuto