Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window positioning is broken on RTL languages with multiple screens #164

Closed
yshavit opened this issue Oct 12, 2020 · 1 comment
Closed

window positioning is broken on RTL languages with multiple screens #164

yshavit opened this issue Oct 12, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@yshavit
Copy link
Owner

yshavit commented Oct 12, 2020

Followup from #90.
yshavit added a commit that referenced this issue Oct 12, 2020
@yshavit
Fix window positioning with multiple screens
b8f0439 
NSStatusBarButton's button.window doesn't seem to change until after it
displays, so I can't just rely on it to figure out where to open the PTN
or daily report window. Instead, I:

  1. Find the button bar's window
  2. Find how far that window is from its screen's right edge
  3. Find the screen that the mouse is currently in
  4. Calculate the point that's similarly far from that screen's right
      edge

This won't work for RTL screens, unfortunately. If a user has an RTL
configuration and one screen, then it doesn't matter much whether we
calculate the button's distance from the left or the right. But with
multiple screens, we want to calculate the distance from the left, since
that's where the user status items are anchored. I don't know how to get
at that information, so I filed #164 to follow up on it.

This fixes #90.
@yshavit yshavit mentioned this issue Oct 12, 2020
Merged
@yshavit yshavit added the bug Something isn't working label Oct 17, 2020
@yshavit
Copy link
Owner Author

yshavit commented Jun 5, 2022

Closing this because RTL is generally not supported right now. If I want to support it later, I need to do a pretty full review.

@yshavit yshavit closed this as completed Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yshavit