Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove win32 builds altogether #85

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

eddiebergman
Copy link
Collaborator

@eddiebergman eddiebergman commented Oct 10, 2022

tldr; Fully dropped building prebuilt binaries for win32 because scipy finally did it too, they said they would a while ago but only fully did it 2 days back.


So it seems that Scipy updated to 1.9.2 2 days ago (08/10/22) and as part of that, they stopped releasing win32 completely. This meant when building GraKeL, it would download the source of scipy and try to compile it manually.

Ctrl + f for win32 and you'll see they dropped it between the two versions

It seems odd they would drop it with a minor release so I went looking at their github.

One issue specifically asks about Python 3.10 which I had disabled previously but one of the maintainers replied in there, saying they would drop win32 wheels from scipy>=1.8. There was however, still win32 wheels available from 1.8.0 -> 1.9.1.

There is also an issue from 2 days ago where they apparently stated they updated their build infrastructure which I guess is where they finally dropped it. Looking at the workflow runs they linked in that issue, there's no build for win32 at all so I guess from this point on it's fully dropped support for pre-built win32 wheels.

So the choices are essentially (in order of recommendation):

  • To roll with scipy and just follow their lead on dropping win32 wheels
  • To upperbound scipy<=1.9.1
  • To somehow install the toolchain needed to get scipy to build on github action servers.
    • If it were simple, scipy would just do it themselves
    • ...How da heck do you compile their underlying FORTRAN?

I went with the first because, well, it's easiest and upperbounding will lead to similar problems in the future, someone want's GraKeL and the newest scikit learn, and they will both have conflicting scipy versions.


@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #85 (a345c30) into master (af0049c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files          37       37           
  Lines        7059     7059           
=======================================
  Hits         4889     4889           
  Misses       2170     2170           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eddiebergman eddiebergman merged commit b4607aa into ysig:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant