Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr; Fully dropped building prebuilt binaries for
win32
because scipy finally did it too, they said they would a while ago but only fully did it 2 days back.So it seems that Scipy updated to
1.9.2
2 days ago (08/10/22) and as part of that, they stopped releasingwin32
completely. This meant when buildingGraKeL
, it would download the source ofscipy
and try to compile it manually.Ctrl + f for
win32
and you'll see they dropped it between the two versionsIt seems odd they would drop it with a minor release so I went looking at their github.
One issue specifically asks about
Python 3.10
which I had disabled previously but one of the maintainers replied in there, saying they would dropwin32
wheels fromscipy>=1.8
. There was however, stillwin32
wheels available from1.8.0 -> 1.9.1
.There is also an issue from 2 days ago where they apparently stated they updated their build infrastructure which I guess is where they finally dropped it. Looking at the workflow runs they linked in that issue, there's no build for
win32
at all so I guess from this point on it's fully dropped support for pre-builtwin32
wheels.So the choices are essentially (in order of recommendation):
scipy
and just follow their lead on droppingwin32
wheelsscipy<=1.9.1
scipy
to build on github action servers.I went with the first because, well, it's easiest and upperbounding will lead to similar problems in the future, someone want's GraKeL and the newest scikit learn, and they will both have conflicting scipy versions.