Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11 issue githubのapi通信を記述している場所をAPIラッパーライブラリ?のoctokitを使用して書き換えたいです #12

Merged
merged 1 commit into from
May 22, 2023

Conversation

george0528
Copy link
Contributor

@george0528 george0528 commented May 21, 2023

関連チケット

#11

概要

  • githubのapi通信の際のライブラリをnode-fetchからoctokitに変更した
  • それに伴う型の変更などを行った

動作確認方法

どのような動作確認が必要か書いてください。

  • 言語をjavascript、並び順をstarでリポジトリを検索した際に検索結果が変わらないことをローカルで確認した。
  • jestのテストを回した

気になっているところ/補足

自信のないところや特にレビューしてほしいところ、その他補足したいことがあれば記載してください。

@vercel
Copy link

vercel bot commented May 21, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @ysknsid25 on Vercel.

@ysknsid25 first needs to authorize it.

@george0528 george0528 changed the base branch from master to dev May 21, 2023 12:43
@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
booby ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 9:38am

Copy link
Owner

@ysknsid25 ysknsid25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます、LGTMです!

@ysknsid25 ysknsid25 merged commit 1cfed58 into ysknsid25:dev May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants