Skip to content

Commit

Permalink
[postprocessor/EmbedThumbnail,postprocessor/FFmpegMetadata] Fix error…
Browse files Browse the repository at this point in the history
… on attaching thumbnails and info json for mkv/mka (#6647)

Authored by: Lesmiscore

Current yt-dlp code never hit this bug, but would hit once filename sanitization gets better
  • Loading branch information
Lesmiscore committed Mar 27, 2023
1 parent 95a383b commit 0f0875e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion yt_dlp/postprocessor/embedthumbnail.py
Expand Up @@ -107,7 +107,7 @@ def run(self, info):
options.extend(['-map', '-0:%d' % old_stream])
new_stream -= 1
options.extend([
'-attach', thumbnail_filename,
'-attach', self._ffmpeg_filename_argument(thumbnail_filename),
'-metadata:s:%d' % new_stream, 'mimetype=%s' % mimetype,
'-metadata:s:%d' % new_stream, 'filename=cover.%s' % thumbnail_ext])

Expand Down
2 changes: 1 addition & 1 deletion yt_dlp/postprocessor/ffmpeg.py
Expand Up @@ -809,7 +809,7 @@ def _get_infojson_opts(self, info, infofn):
new_stream -= 1

yield (
'-attach', infofn,
'-attach', self._ffmpeg_filename_argument(infofn),
f'-metadata:s:{new_stream}', 'mimetype=application/json',
f'-metadata:s:{new_stream}', 'filename=info.json',
)
Expand Down

0 comments on commit 0f0875e

Please sign in to comment.