Skip to content

Commit

Permalink
[TikTok] Fix URLs with user id (#3295)
Browse files Browse the repository at this point in the history
Closes #3243
Authored by: hatienl0i261299
  • Loading branch information
Ha Tien Loi committed Apr 4, 2022
1 parent 04f3fd2 commit 5fa3c9a
Showing 1 changed file with 35 additions and 2 deletions.
37 changes: 35 additions & 2 deletions yt_dlp/extractor/tiktok.py
Expand Up @@ -263,7 +263,7 @@ def extract_addr(addr, add_meta={}):

return {
'id': aweme_id,
'title': aweme_detail['desc'],
'title': aweme_detail.get('desc'),
'description': aweme_detail['desc'],

This comment has been minimized.

Copy link
@MinePlayersPE

MinePlayersPE Apr 4, 2022

Contributor

? Either change both or just not bother

This comment has been minimized.

Copy link
@pukkandan

pukkandan Apr 4, 2022

Member

oops, didn't notice description

'view_count': int_or_none(stats_info.get('play_count')),
'like_count': int_or_none(stats_info.get('digg_count')),
Expand Down Expand Up @@ -457,6 +457,30 @@ class TikTokIE(TikTokBaseIE):
'comment_count': int,
},
'expected_warnings': ['Video not available']
}, {
# Video without title and description
'url': 'https://www.tiktok.com/@pokemonlife22/video/7059698374567611694',
'info_dict': {
'id': '7059698374567611694',
'ext': 'mp4',
'title': 'N/A',

This comment has been minimized.

Copy link
@MinePlayersPE

MinePlayersPE Apr 4, 2022

Contributor

Also ?
This isn't correct based on

info_dict['title'] = f'{info_dict["extractor"]} video #{info_dict["id"]}'

'description': '',
'uploader': 'pokemonlife22',
'creator': 'Pokemon',
'uploader_id': '6820838815978423302',
'uploader_url': 'https://www.tiktok.com/@MS4wLjABAAAA0tF1nBwQVVMyrGu3CqttkNgM68Do1OXUFuCY0CRQk8fEtSVDj89HqoqvbSTmUP2W',
'track': 'original sound',
'timestamp': 1643714123,
'duration': 6,
'thumbnail': r're:^https?://[\w\/\.\-]+(~[\w\-]+\.image)?',
'upload_date': '20220201',
'artist': 'Pokemon',
'view_count': int,
'like_count': int,
'repost_count': int,
'comment_count': int,
},
'expected_warnings': ['Video not available']
}, {
# Auto-captions available
'url': 'https://www.tiktok.com/@hankgreen1/video/7047596209028074758',
Expand Down Expand Up @@ -521,6 +545,15 @@ class TikTokUserIE(TikTokBaseIE):
'thumbnail': r're:https://.+_1080x1080\.webp'
},
'expected_warnings': ['Retrying']
}, {
'url': 'https://www.tiktok.com/@6820838815978423302',
'playlist_mincount': 5,
'info_dict': {
'id': '6820838815978423302',
'title': '6820838815978423302',
'thumbnail': r're:https://.+_1080x1080\.webp'
},
'expected_warnings': ['Retrying']
}, {
'url': 'https://www.tiktok.com/@meme',
'playlist_mincount': 593,
Expand Down Expand Up @@ -593,7 +626,7 @@ def _real_extract(self, url):
webpage = self._download_webpage(url, user_name, headers={
'User-Agent': 'facebookexternalhit/1.1 (+http://www.facebook.com/externalhit_uatext.php)'
})
user_id = self._html_search_regex(r'snssdk\d*://user/profile/(\d+)', webpage, 'user ID')
user_id = self._html_search_regex(r'snssdk\d*://user/profile/(\d+)', webpage, 'user ID', default=None) or user_name

videos = LazyList(self._video_entries_api(webpage, user_id, user_name))
thumbnail = traverse_obj(videos, (0, 'author', 'avatar_larger', 'url_list', 0))
Expand Down

0 comments on commit 5fa3c9a

Please sign in to comment.