make impersonate_target_available and `get_available_impersonate_ta…

…rgets` internal only
yt-dlp · Mar 15, 2024 · 7bf1abb · 7bf1abb
1 parent fbafe3d
commit 7bf1abb
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/test/test_networking.py b/test/test_networking.py
@@ -1633,14 +1633,14 @@ def _send(self, request: Request):
 
         with FakeYDL() as ydl:
             ydl._request_director = ydl.build_request_director(handlers)
-            assert set(ydl.get_available_impersonate_targets()) == {
+            assert set(ydl._get_available_impersonate_targets()) == {
                 (ImpersonateTarget('chrome'), 'chrome'),
                 (ImpersonateTarget('firefox'), 'firefox'),
                 (ImpersonateTarget('edge'), 'edge')
             }
-            assert ydl.impersonate_target_available(ImpersonateTarget('firefox'))
-            assert ydl.impersonate_target_available(ImpersonateTarget())
-            assert not ydl.impersonate_target_available(ImpersonateTarget('safari'))
+            assert ydl._impersonate_target_available(ImpersonateTarget('firefox'))
+            assert ydl._impersonate_target_available(ImpersonateTarget())
+            assert not ydl._impersonate_target_available(ImpersonateTarget('safari'))
 
     @pytest.mark.parametrize('proxy_key,proxy_url,expected', [
         ('http', '__noproxy__', None),

diff --git a/yt_dlp/YoutubeDL.py b/yt_dlp/YoutubeDL.py
@@ -719,7 +719,7 @@ def check_deprecated(param, option, suggestion):
 
         impersonate_target = self.params.get('impersonate')
         if impersonate_target is not None:
-            if not self.impersonate_target_available(impersonate_target):
+            if not self._impersonate_target_available(impersonate_target):
                 raise YoutubeDLError(
                     f'Impersonate target "{self.params.get("impersonate")}" is not available. '
                     f'Use --list-impersonate-targets to see available targets. '
@@ -4089,15 +4089,16 @@ def _opener(self):
         handler = self._request_director.handlers['Urllib']
         return handler._get_instance(cookiejar=self.cookiejar, proxies=self.proxies)
 
-    def get_available_impersonate_targets(self):
+    def _get_available_impersonate_targets(self):
+        # todo(future): make available as public API
         return list(
             itertools.chain.from_iterable(
                 [[(target, rh.RH_NAME) for target in rh.supported_targets]
                  for rh in self._request_director.handlers.values()
                  if isinstance(rh, ImpersonateRequestHandler)]))
 
-    def impersonate_target_available(self, target):
-        # This assumes that all handlers that support impersonation subclass ImpersonateRequestHandler
+    def _impersonate_target_available(self, target):
+        # todo(future): make available as public API
         return any(
             rh.is_supported_target(target)
             for rh in self._request_director.handlers.values()

diff --git a/yt_dlp/__init__.py b/yt_dlp/__init__.py
@@ -996,7 +996,7 @@ def _real_main(argv=None):
                 (ImpersonateTarget('chrome', os='android'), 'curl_cffi'),
             ]
 
-            available_targets = ydl.get_available_impersonate_targets()
+            available_targets = ydl._get_available_impersonate_targets()
 
             rows = [
                 [target.client or '-', target.version or '-', target.os or '-', target.os_vers or '-', handler]