Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[build:Makefile] Ensure compatibility with BSD
make
(#9210)
Authored by: bashonly
- Loading branch information
Showing
1 changed file
with
12 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaa1a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after applying these latest changes to Makefile my terminal (MacOS, M1 chip) would just fail to build yt-dlp file. Please advise - Makefile:44: *** GNU Make 4+ or BSD Make is required. Stop.
beaa1a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@someziggyman The error message explains what's wrong.
Solution for macOS:
brew install make
gmake yt-dlp
beaa1a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. is there any reason why internal macOS 'make' is no longer good? I know sometimes their Terminal tools or libs may get outdated. Just curious. (non programmer or coder here. just occasional scripts user)
beaa1a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@someziggyman try running
make --version
. If it's GNU Make and it's older than 4.0, that would be why. If it doesn't output anything, then it's some problematic variant of BSD Make that we would need to investigate further.I will be opening a PR shortly to restore compatibility with older GNU Make versions... I had assumed macOS used BSD Make since they use BSD grep/sed/etc... but can't assume anything with macOS apparently
beaa1a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. thanks for the explanation. indeed the version is GNU Make 3.81 located in /usr/bin/make on macOS Sonoma (if you need it).