Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/crunchyroll] Fix stream extraction #10005

Merged
merged 2 commits into from
May 22, 2024

Conversation

bashonly
Copy link
Member

Credit to @stratuma for finding this solution. Also thanks to @napgiver for bringing this to my attention

The extractor needs to use the Switch user-agent when making the stream endpoint request, and subsequently needs to invalidate the stream token to prevent being rate-limited.

This PR also fixes an oversight in cb2fb4a that caused the extractor to not always make metadata available, as noted here

Fixes #9994

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Fix or improvement to an extractor (Make sure to add/update tests)

@bashonly bashonly added the site-bug Issue with a specific website label May 22, 2024
@bashonly bashonly requested a review from Grub4K May 22, 2024 19:53
@bashonly bashonly merged commit f281663 into yt-dlp:master May 22, 2024
6 checks passed
@bashonly bashonly deleted the fix/crunchy-again branch May 22, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[crunchyroll] Failed to download stream info: HTTP Error 403: Forbidden
2 participants