[RedGifsSearch] Add RedGifs search (and user) extractor #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinePlayersPE
suggested changes
Nov 27, 2021
|
#1631 has been merged. Please fix the merge conflicts |
…GifsSearch can both use it
Deer-Spangle
force-pushed
the
redgifs-playlist
branch
from
fb92f85
to
74d3d69
Compare
|
Rebased onto master, reworked my extractor to extend RedGifsIE, and pulled out common gif parsing. |
|
Also added a RedGifsUser extractor, while I'm here |
Deer-Spangle
changed the title
pukkandan
requested changes
Nov 27, 2021
pukkandan
requested changes
Nov 27, 2021
… be subclassed by
|
Thanks for the cleanup there! |
pukkandan
approved these changes
Nov 28, 2021
gaming-hacker
added a commit
to gaming-hacker/yt-dlp
that referenced
this pull request
Nov 29, 2021
* commit 'ee8dd27a7351841e1de8cebf8311b69fbef09eab': (39 commits) [cleanup] Add deprecation warnings [cleanup] Misc cleanup Closes yt-dlp#1805, closes yt-dlp#1800 [cleanup] Refactor `JSInterpreter._seperate` [build] Use `workflow_dispatch` for release [build] Fix MacOS Build Closes yt-dlp#1624 [build] Save Git HEAD at release alongside version info Option `--wait-for-video` to wait for scheduled streams Option `--break-per-input` to apply --break-on... to each input URL Fix --break-on-archive when pre-checking [downloader] Add colors to download progress [youtube] Decrypt n-sig for URLs with `ratebypass` Closes yt-dlp#1796 [vimeo] Sort http formats higher Closes yt-dlp#1821 [Instagram] Display more login errors (yt-dlp#1822) [RedGifs] Add Search and User extractors (yt-dlp#1808) [NovaEmbed] Fix extractor (yt-dlp#1814) Fix logic error in report_unplayable_conflict [tiktok:user] Set `webpage_url` correctly Closes yt-dlp#1802 [twitch:vod] Extract live status (yt-dlp#1722) Authored by: DEvmIb Ensure directory exists when checking formats [EmbedSubtitles] Slightly relax duration check and related cleanup Closes yt-dlp#1385 ... # Conflicts: # Makefile
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
I'm adding a playlist extract for RedGifs searches.
There's another PR Ive noted above, #1631 which does redgifs pages. I'm happy to resolve merge conflicts if that goes in first, and neaten things up. Or to move this to a different file to avoid conflicts. I'm open to your suggestion there.
I wasn't sure whether to implement paging in this also?
As in, should this scrape through all pages, or just the specified page?