-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reliable way of getting video and audio containing formats from JSON #4373
Comments
if Eg: PS: Don't close the issue. I'll take a look at your suggestions about the README later |
Wow that was fast, thank you. |
I just tested it, and unfortunately this still recognizes non video formats from this json as videos. But I guess that just means that yt-dlp just doesn't know that they are not videos. As a solution to that, I ended up also checking |
According to the json given in the issue, yt-dlp thinks they are videos. But I cannot reproduce their result and would need more info to say what exactly is hapenning |
Every format that was not detected as a video format was added to the audio tracks. This resulted in e.g. YouTube storyboards from ending up in the list of audio tracks. Now formats that are already known to be neither video formats nor audio formats, will also not end up in any track list. yt-dlp/yt-dlp#4373 (comment)
Every format that was not detected as a video format was added to the audio tracks. This resulted in e.g. YouTube storyboards from ending up in the list of audio tracks. Now formats that are already known to be neither video formats nor audio formats, will also not end up in any track list. yt-dlp/yt-dlp#4373 (comment)
Every format that was not detected as a video format was added to the audio tracks. This resulted in e.g. YouTube storyboards from ending up in the list of audio tracks. Now formats that are already known to be neither video formats nor audio formats, will also not end up in any track list. Formats where it is unknown if they are video or audio get added to tracks if `force_all_formats` is used, otherwise only formats that are known to contain video or audio become video or audio tracks respectively. yt-dlp/yt-dlp#4373 (comment)
Every format that was not detected as a video format was added to the audio tracks. This resulted in e.g. YouTube storyboards from ending up in the list of audio tracks. Now formats that are already known to be neither video formats nor audio formats, will also not end up in any track list. Formats where it is unknown if they are video or audio get added to tracks if `force_all_formats` is used, otherwise only formats that are known to contain video or audio become video or audio tracks respectively. yt-dlp/yt-dlp#4373 (comment)
Every format that was not detected as a video format was added to the audio tracks. This resulted in e.g. YouTube storyboards from ending up in the list of audio tracks. Now formats that are already known to be neither video formats nor audio formats, will also not end up in any track list. Formats where it is unknown if they are video or audio get added to tracks if `force_all_formats` is used, otherwise only formats that are known to contain video or audio become video or audio tracks respectively. yt-dlp/yt-dlp#4373 (comment)
Every format that was not detected as a video format was added to the audio tracks. This resulted in e.g. YouTube storyboards from ending up in the list of audio tracks. Now formats that are already known to be neither video formats nor audio formats, will also not end up in any track list. Formats where it is unknown if they are video or audio get added to tracks if `force_all_formats` is used, otherwise only formats that are known to contain video or audio become video or audio tracks respectively. yt-dlp/yt-dlp#4373 (comment)
Every format that was not detected as a video format was added to the audio tracks. This resulted in e.g. YouTube storyboards from ending up in the list of audio tracks. Now formats that are already known to be neither video formats nor audio formats, will also not end up in any track list. Formats where it is unknown if they are video or audio get added to tracks if `force_all_formats` is used, otherwise only formats that are known to contain video or audio become video or audio tracks respectively. yt-dlp/yt-dlp#4373 (comment)
Every format that was not detected as a video format was added to the audio tracks. This resulted in e.g. YouTube storyboards from ending up in the list of audio tracks. Now formats that are already known to be neither video formats nor audio formats, will also not end up in any track list. Formats where it is unknown if they are video or audio get added to tracks if `force_all_formats` is used, otherwise only formats that are known to contain video or audio become video or audio tracks respectively. yt-dlp/yt-dlp#4373 (comment)
Every format that was not detected as a video format was added to the audio tracks. This resulted in e.g. YouTube storyboards from ending up in the list of audio tracks. Now formats that are already known to be neither video formats nor audio formats, will also not end up in any track list. Formats where it is unknown if they are video or audio get added to tracks if `force_all_formats` is used, otherwise only formats that are known to contain video or audio become video or audio tracks respectively. yt-dlp/yt-dlp#4373 (comment)
Checklist
Please make sure the question is worded well enough to be understood
I am currently working on the ytdl_hook from mpv.
It runs
yt-dlp
with-J
and then parses the JSON.Currently it just assumes that everything that doesn't have a
vcodec
set (== null
or== 'none'
) is an audio format. The problem with that is that things like storyboards from YouTube also get recognized as audio formats.The README says:
Indicating that logic to be true.
But the README also says:
Implying that all formats that have audio are guaranteed to have
acodec != null
andacodec != 'none'
.The README however never states that
!= null
and!= none
are guaranteed for vcodec or acodec if the format contains video or audio respectively.Is there a reliable way of getting all the formats containing video and all the formats containing audio without also getting any other formats (e.g. storyboards from YouTube) from the JSON? Also it would be good to know if you know that solution to also work for youtube-dl.
P.S. I'm not a native english speaker, so maybe I'm wrong on this.
The README contains
but I think the word 'either' indicates xor, where as this should be a logical or. I suggest changing it to 'video and/or audio' to make it less ambiguous.
Provide verbose output that clearly demonstrates the problem
yt-dlp -vU <your command line>
)[debug] Command-line config
) and insert it belowComplete Verbose Output
No response
The text was updated successfully, but these errors were encountered: