New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crunchyroll beta - KeyError('byId') #4692
Comments
It seems they changed the datastructure embedded in the page. It's |
I don't know if it's due to some geoblock, but the website doesn't redirect me to any video either. If that is global, we should just throw an error when not logged in. We can't be expected to support redirects that crunchyroll itself no longer supports |
Crunchyroll never redirected you to the actual video on the non-beta site iirc. It always dumped you on the main page. I see 2 options here:
Thoughts on option 2? |
if you can implement it, why not |
Ok, then, will do. It's dead simple, really. In |
@tejing1 your PR seems to fix the inital problem but seems fail for me in the end I tried using cookies, netrc and username + password via cli - logs seem identical for all of em. old URL style>
new URL style>
|
@nachfuellbar Can't reproduce. Just tried the same url with |
Also, incidentally, you'll need to use |
Oh, hmm. Something odd is happening after all: |
@tejing1 thanks for the help |
Good, but it's still strange to me that that combination of events could happen at all. We had a bug we could never figure out a while back where it was redirecting in a loop, which seems to have a similar underlying cause. Somehow crunchyroll thinks you're logged in, but yt-dlp thinks you're not, and I'm not sure what the disconnect is between crunchyroll's conditions and yt-dlp's. iirc that bug also happened with |
Don't know if this helps but they removed the option to opt out of beta for logged in users some time ago. Same here if I unterstand - it uses the cookie but doesn't think it's logged in Maybe because the cookies used on beta.crunchyroll.com are from www.crunchyroll.com, beta.crunchyroll.com and crunchyroll.com? At least it seems like it uses cookies from all 3 domains |
Yeah, I'm well aware of the thing where they force logged in users to beta in some regions. Mine (US) is one of them. My code in yt-dlp takes different paths based on whether a cookie with name |
Something else - seems like the subtitles didn't get downloaded with --sub-lang en-US --sub-lang en-US
--all-subs
|
You have to add |
@pukkandan thanks for spotting it - thought i had it in config but you are right, the log says otherwise |
The problem is that The solution could be something like the one in Django, overwriting |
Now that sounds like the reason! Thanks for tracking that down. |
No problem. Should we track this in another issue entirely since it could potentially affect every extractor using |
I'd say so, yeah, especially since it isn't actually even related to the OP here. |
DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
Checklist
Region
No response
Provide a description that is worded well enough to be understood
The error occurs when openening URL from the beta UI w/o providing authentication info to yt-dlp:
An extractor error has occurred. (caused by KeyError('byId'));
Provide verbose output that clearly demonstrates the problem
yt-dlp -vU <your command line>
)[debug] Command-line config
) and insert it belowComplete Verbose Output
The text was updated successfully, but these errors were encountered: