Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vimeo] Add support for VHX subscriptions #4849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stanciuadrian
Copy link

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Adds support for https://embed.vhx.tv/subscriptions/ URLs.

Based on the https://embed.vhx.tv/videos/ extractor.
The URL needs the vimeo=1 parameter to work.

Fixes #4560

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan
Copy link
Member

Add tests

@stanciuadrian
Copy link
Author

These are mostly paid-for videos.
I'll try to find an example that doesn't require a cookies.txt file.

@pukkandan
Copy link
Member

Even so, you can still add a test and run it yourself. Once you have ensured the test passes, add 'skip': 'Needs authenticated cookies' to skip it from automated testing

@pukkandan pukkandan added site-request Request to support a new website pending-fixes PR has had changes requested stale-pr PR that has been pending fixes for a long time labels Sep 30, 2022
@pukkandan pukkandan force-pushed the master branch 2 times, most recently from ee280c7 to 7aeda6c Compare May 24, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-fixes PR has had changes requested site-request Request to support a new website stale-pr PR that has been pending fixes for a long time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants