-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Broken] nbcolympics stream #617
Comments
I don't have another MSO account to confirm this with, but I'm nearly 100% certain it's because the 2020 Olympics uses a different scheme now compared to 2018, and will require the extractor to be modified. |
Yeah, it looks like that PR author has done some of the work to fix the extractor. |
Hi, I was just leaving a comment on ytdl-org/youtube-dl#29665! I think my youtube-dl PR is functional though maybe not yet ready to merge. I'm not sure how this project differs from that one but it looks like any merge on that end would eventually show up here? |
@nchilada Yes, if your PR gets merged upstream, it will make its way here too. If possible, I would like to get it merged without waiting for if/when upstream merges it. I sometimes just take the PR and merge it myself. But since I cannot test this, you or someone else will have to make a PR here and work with me to get this merged |
Want my account? |
You can DM me on discord, but since I'm from India, I don't know whether it is actually accessible to me |
You don't need any account to replicate this, just vpn your way to the us and try.
|
@fosam Your log seems to be showing a different problem than the one this issue is adressing |
The nbcolympics:stream extractor is currently not working, although @nchilada has a fix. This is slightly different, though: the URL doesn't match the nbcolympics extractor |
I think you are confusing yt-dlp features with youtube-dl. There are no multithreaded downloads in ytdl |
Well, I mean that the alternate downloaders (e.g. aria2c) themselves may have multiple workers. |
Downloading fragmented videos with aria2c is also a yt-dlp only feature :D |
Alright, I keep getting my wires crossed somehow...! |
Fixes: yt-dlp#617 (comment) Authored by: wesnm
PR: ytdl-org/youtube-dl#29688 Closes: yt-dlp#617, ytdl-org/youtube-dl#29665 * Livestreams are untested * If using ffmpeg as downloader, v4.3+ is needed since `-http_seekable` option is necessary * Instead of making a seperate key for each arg that needs to be passed to ffmpeg, I made `_ffmpeg_args` * This deprecates `_seekable`, but the option is kept for compatibility Authored by: nchilada, pukkandan
Checklist
Verbose log
Description
I'm attempting to download VOD of the olympics from NBC using SlingTV and I am getting this error.
I used the web url as well as trying to find m3u8 links in the dev menu, both resulted in a failure
I was told on discord to tag @wesnm
TY
The text was updated successfully, but these errors were encountered: