Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Twitch] !is_live filter not excluding vod of current live in latest version #6494

Closed
9 of 11 tasks
ouaklgdfhg opened this issue Mar 9, 2023 · 0 comments · Fixed by #6500
Closed
9 of 11 tasks

[Twitch] !is_live filter not excluding vod of current live in latest version #6494

ouaklgdfhg opened this issue Mar 9, 2023 · 0 comments · Fixed by #6500
Labels
site-bug Issue with a specific website triage Untriaged issue

Comments

@ouaklgdfhg
Copy link

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

  • I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

Region

France

Provide a description that is worded well enough to be understood

The current livestream of a twitch channel appears in the VOD tab even before the live is finished.
Previously the VOD of the current live was correctly detected as being live and was excluded by this filter : --match-filter "!is_live"

Since a few days I noticed that I downloaded partial VODs because this filter was not working anymore. VOD of the current live is not excluded by the filter.

Below is the verbose output with the latest version which is the one I use and a (as of the time of writing) link to a VOD of a stream still live. As you can see it is not excluded and starts downloading.
To reproduce : add the filter and try downloading the vod of a stream still live.

To help analyze I don't think it is a change from twitch side, because I tried downgrading to version 2023.02.17 which is the one I used before and it appears that the filter is still working in this version, VODs of current live was correctly excluded by the "!is_live" filter.

Thank you for the work on this very helpful tool.

Provide verbose output that clearly demonstrates the problem

  • Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
  • If using API, add 'verbose': True to YoutubeDL params instead
  • Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output

[debug] Command-line config: ['-vU', '--match-filter', '!is_live', '-o', '..\\Media\\Twitch\\%(uploader)s\\%(upload_date)s - %(title)s\\%(id)s.%(ext)s', 'https://www.twitch.tv/videos/1760343238']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version stable@2023.03.04 [392389b7d] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg N-109937-g05438db024-20230228 (setts), ffprobe N-109937-g05438db024-20230228
[debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version: stable@2023.03.04, Current version: stable@2023.03.04
Current Build Hash: 5590c57bd0433ed239a2deaaf92e2ad6f37fe50f53664c821575cafe106a9421
yt-dlp is up to date (stable@2023.03.04)
[twitch:vod] Extracting URL: https://www.twitch.tv/videos/1760343238
[twitch:vod] 1760343238: Downloading stream metadata GraphQL
[twitch:vod] 1760343238: Downloading video access token GraphQL
[twitch:vod] 1760343238: Downloading m3u8 information
[twitch:vod] 1760343238: Downloading storyboard metadata JSON
WARNING: [twitch:vod] Unable to download JSON metadata: HTTP Error 403: Forbidden
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] v1760343238: Downloading 1 format(s): 1080p60
[debug] Invoking hlsnative downloader on "https://d2nvs31859zcd8.cloudfront.net/e61910268d0d54dad290_lcs_41940811147_1678394435/chunked/index-dvr.m3u8"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 688
[download] Destination: ..\Media\Twitch\LCS\20230309 - 2023 LCS Spring Split - Week 7 Day 1\v1760343238.mp4
[debug] File locking is not supported. Proceeding without locking
[download]   0.6% of ~   6.08GiB at    3.72MiB/s ETA 27:41 (frag 4/688)
ERROR: Interrupted by user
@ouaklgdfhg ouaklgdfhg added site-bug Issue with a specific website triage Untriaged issue labels Mar 9, 2023
pukkandan pushed a commit that referenced this issue Mar 10, 2023
Closes #6494
Authored by: elyse0
elyse0 added a commit to elyse0/yt-dlp that referenced this issue Mar 12, 2023
qa4FKm3mUr added a commit to qa4FKm3mUr/yt-dlp that referenced this issue Jul 30, 2023
* [utils] Add hackish 'now' support for --download-sections

* [utils] Add microseconds to unified_timestamp

* [common] Extract start and end keys for Dash fragments

* [utils] Allow using local timezone for 'now' timestamps

* Use local timezone for download sections

* Add fixme in modified parse_chapters function

A range like '*(now-1hour)-(now-30minutes)' doesn't work

* [youtube] Support --download-sections for YT Livestream from start

* Create last_segment_url only if necessary

* Improve parse_chapters comments

* Fix linter

* [extractor/iq] Set more language codes (yt-dlp#6476)

Authored by: D0LLYNH0

* [extractor/opencast] Add ltitools to `_VALID_URL` (yt-dlp#6371)

Authored by: C0D3D3V

* [downloader/curl] Fix progress reporting

Bug in 8c53322
Closes yt-dlp#6490

* [extractor/youtube] Bypass throttling for `-f17`

and related cleanup

Thanks @AudricV for the finding

* [extractor/twitch] Fix `is_live` (yt-dlp#6500)

Closes yt-dlp#6494
Authored by: elyse0

* [extractor/cbc:gem] Update `_VALID_URL` (yt-dlp#6499)

Authored by: makeworld-the-better-one
Closes yt-dlp#6395

* Support loading info.json with a list at it's root

* [extractor/hidive] Fix login

Fixes yt-dlp#6493 (comment)

* [extractor/opencast] Fix format bug (yt-dlp#6512)

Authored by: C0D3D3V

* [extractor/rokfin] Re-construct manifest url (yt-dlp#6507)

Authored by: vampirefrog

* [extractor/youtube] Add client name to `format_note` when `-v` (yt-dlp#6254)

Authored by: Lesmiscore, pukkandan

* [extractor/youtube] Add extractor-arg `include_duplicate_formats`

* [extractor/youtube] Construct fragment list lazily

Building fragment list for all formats take significant time for large videos

* Support negative durations

* Revert "[utils] Allow using local timezone for 'now' timestamps"

This reverts commit 1799a6a.

* Add fragment count

* Fix unified_timestamp

* Remove tz_aware date code

* Add debug for selected section

* Add initial documentation

* Fix linter

* Fix linter

* Allow days in parse_duration

* Improve option documentation

* Add some documentation

* Lock less agressively

This gives a speed performance of about 30%

* Fix return values of _extract_sequence_from_mpd

* Always compute last_seq

* Support for epoch timestamps

* Update options docs

* Restore README.md

I think this is auto-generated by some script

* Add warning about --download-sections without --live-from-start

* Fix bug after merge

* Update yt_dlp/options.py

* Cleanup

---------

Co-authored-by: Elyse <26639800+elyse0@users.noreply.github.com>
Co-authored-by: Sophire <115919609+sophie0x@users.noreply.github.com>
Co-authored-by: D0LLYNH0 <67797325+D0LLYNH0@users.noreply.github.com>
Co-authored-by: Daniel Vogt <daniel-vogt@mail.de>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: makeworld <25111343+makeworld-the-better-one@users.noreply.github.com>
Co-authored-by: Daniel Vogt <c0d3d3v@mag-keinen-spam.de>
Co-authored-by: vampirefrog <vampirefrog@users.noreply.github.com>
Co-authored-by: Lesmiscore <nao20010128@gmail.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <bashonly@bashonly.com>
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website triage Untriaged issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant