New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPError 426: 'Upgrade Required' when downloading from CBC #6716
Comments
Is this a bug with the yt-dlp extractor? Downloading 720p works (directly) but -F doesn't show the 1080p stream. |
I can confirm this issue, I will look into it. Worst case I will be free to explore this in a couple weeks. |
@makew0rld thank you, I for one will appreciate it. |
I also have this issue, the http traffic shows an interesting Upgrade header:
|
So we need to upgrade the protocol sent from yt-dlp. |
I will investigate what the browser client does, as that is what is best to copy. But when I actually visit the URL, while it does return HTTP code 426 and have that non-standard Upgrade header, all the expected JSON metadata is there. I suspect if youtube-dl just ignored the HTTP code things would continue working fine. Will look more into this later as mentioned above. |
@makew0rld I wanted to test your theory and was able to confirm that you are correct. As a test I added Before:
After:
|
My above message wasn't necessarily a suggestion for a patch, was just a dirty confirmation of the theory. This would be more gracious: This line can be modified: https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/extractor/cbc.py#L352 from: to |
@jo-nike Brilliant! Thanks man. |
I update both my files and we're back in business! thanks a lot!!! |
Be careful tho, updating common.py like I suggested in the first message could compromise other extractors. It wasn't meant to be a fix at all. Great that it work but look out for a fix in the future and update your code accordingly to avoid undesired results with other extractors. |
Completely understand! In my case I only use it for CBC GEM and nothing else. |
Ok I can confirm the browser client is doing something different now, it no longer accesses the URL currently used by yt-dlp. It's good to see #6781, thanks @jo-nike. But I expect this method will break in the future when CBC removes that API. I would agree that this issue can be closed once #6781 is merged though. |
Just confirming that I tried today with |
Side question: I installed the patched extractor at Did I missunderstand the readme plugins sideload section? TIA. |
|
Perfect, thx a lot. |
Closes yt-dlp#6716 Authored by: jo-nike
DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
Checklist
Provide a description that is worded well enough to be understood
Hello! I was downloading from CBC just fine for a few days and everything was fine. Suddenly all my CBC downloads started failing with the following error:
Provide verbose output that clearly demonstrates the problem
yt-dlp -vU <your command line>
)'verbose': True
toYoutubeDL
params instead[debug] Command-line config
) and insert it belowComplete Verbose Output
The text was updated successfully, but these errors were encountered: