Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/niconico] Download comments from the new endpoint #6773

Merged
merged 3 commits into from Apr 11, 2023

Conversation

Lesmiscore
Copy link
Contributor

Closes #6760

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

Fixes #6760

Things to consider:

  • new and legacy formats have different structure; should we assign an another language for the new one?
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

yt_dlp/extractor/niconico.py Outdated Show resolved Hide resolved
yt_dlp/extractor/niconico.py Show resolved Hide resolved
Lesmiscore and others added 2 commits April 12, 2023 00:44
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
@Lesmiscore Lesmiscore merged commit 52ecc33 into yt-dlp:master Apr 11, 2023
11 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Niconico] How to download Anime danmaku on Niconico?
2 participants