[ie/niconico] remove unusable legacy danmaku (comments, subtitle) extraction #9209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Hi.
Fixes #8684
See also: #6773
CAUTION: This PR completely removes the code about legacy danmaku extraction.
The "new danmaku extraction" logic works fine, by the way.
Test
It seems that all
/comment/threads/.../server
are empty strings, I guess the legacy endpoint has been shut down.Here is the
api_data
of sm16309076 - 「Thousand Cherry Blossoms」 Played it【Piano】 - ニコニコ動画:Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?