[extractor/rheinmaintv] Add extractor #7311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extractor for rheinmaintv.de.
Add new extractor to _extractors.py.
Fix a potential problem in _html_search_regex: _search_regex may return a tuple when several subpatterns are selected. (Moreover, the result of clean_html is stripped already.)
Fixed the test cases.
Cosmetic chenges.
Fixed indendation. Oops!
Cosmetic changes.
Test cases completed.
Changed comments to make linter (flake8) happy. (Although commented-out code should in fact start with ##.)
Cosmetic changes
Linter (flake8) did not approve the line splits...
Improved video_id and JSON-LD extraction.
Improved/fixed fallbacks.
Use library function instead of quick&dirty solution. (Plus, yet another small change of layout.)
Oops, still overlooked one issue... Use library function instead of new Python method. (Although this part of the code should, hopefully, never be executed.)
Further improved _html_search_regex.
Leave the formats alone. The final extension should be established elsewhere.
If the info_dict contains an extension, save it as the preferred format for merge (if not specified otherwise). In case of a merge, the extension will be overridden by the chosen (best) format without notice (for backwards compatibility, as the comment says). This looks very ugly but still safer than overriding extensions in all available formats. It would probably be much better to leave the info_dict alone.
Revert the change.
Reverted the change and sorted the imports.
Fixed a glitch during the merge.
Consider any format (file extension) in the info_dict when merging video/audio formats.
Added another test and improved a comment.
Undo the latest changes.
old `_VALID_URL` was not matching URLs w/ alphanumeric `display_id`s like https://www.rheinmaintv.de/sendungen/beitrag-video/bricks4kids/vom-22.06.2022/
pukkandan
approved these changes
Jun 22, 2023
yt_dlp/extractor/rheinmaintv.py
Outdated
Comment on lines
95
to
99
| **traverse_obj(json_ld, { | ||
| 'timestamp': 'timestamp', | ||
| 'duration': 'duration', | ||
| 'view_count': 'view_count', | ||
| }), |
There was a problem hiding this comment.
Why not merge_dict with the whole thing?
There was a problem hiding this comment.
I think the original PR author wanted to mix and match, they wanted to give priority to JSON LD for certain fields but also wanted non-JSON LD fallbacks for those (description, title)
But yeah ig merging the whole thing with JSON LD as secondary dict couldn't hurt
yt_dlp/utils/_utils.py
Outdated
Comment on lines
3505
to
3506
| sanitize_codec = functools.partial( | ||
| try_get, getter=lambda x: x[0].split('.')[0].replace('0', '').lower()) |
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: barthelmannk Co-authored-by: barthelmannk <81305638+barthelmannk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5840
PR commit 08d65a6 reapplies a change made in yt-dlp:master commit a538772 that was somehow reverted in 69bec67 - without this fix ismv+isma formats will not merge into mp4 container
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 97e4572
Summary
📺🛠️🐛
This pull request adds a new extractor for Rhein-Main TV videos, by creating the
RheinMainTVIEclass in therheinmaintv.pymodule and importing it in the_extractors.pymodule. It also fixes a bug in theget_compatible_extfunction in theutils/_utils.pymodule, by sanitizing the codec names before checking their compatibility with MP4 containers.Walkthrough
rheinmaintv.pymodule that definesRheinMainTVIEclass (link)_real_extractmethod to parse video information and formats from webpage (link)RheinMainTVIEclass in_extractors.pyand add valid URLs (link)RheinMainTVIEinrheinmaintv.py(link)sanitize_codecfunction inutils/_utils.pyto convert codecs to lowercase (link)