Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/rheinmaintv] Add extractor #7311
[extractor/rheinmaintv] Add extractor #7311
Changes from 36 commits
3242430
fe5a5b5
11a29f8
9b43787
6508252
d4eb78a
b06bf38
68a9421
e5aaa5f
93f9432
a500e20
164827c
7224c30
6a04563
c91da52
542cfa5
bc9503d
b4fe90b
34cd757
636e869
599a9b7
bf4fdb7
fa85dcf
95a84e0
84a959e
64c71f1
cf015ad
2e72388
b3f3e40
01a49eb
af3f553
08d65a6
60d531e
937b761
97e4572
eb98f41
07cb271
9b23e79
011d56b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not merge_dict with the whole thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original PR author wanted to mix and match, they wanted to give priority to JSON LD for certain fields but also wanted non-JSON LD fallbacks for those (
description
,title
)But yeah ig merging the whole thing with JSON LD as secondary dict couldn't hurt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this separately