Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[networking] Fix --legacy-server-connect #7645

Merged
merged 1 commit into from Jul 20, 2023

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Jul 19, 2023

Bugfix for 227bf1a

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at f6508fd

Summary

馃悰馃敡馃И

Fix a typo in the legacy_server_connect option name for network requests. This option allows using older SSL/TLS protocols for compatibility with some servers. The typo was present in both the test file test/test_networking.py and the main file yt_dlp/YoutubeDL.py.

legacy_server_connect
A typo in the code
Fixed in two places

Walkthrough

  • Fix typo in legacy_server_connect option name (link, link)

Bugfix for 227bf1a

Authored by: bashonly
@bashonly bashonly added the bug Bug that is not site-specific label Jul 19, 2023
@bashonly bashonly requested a review from coletdjnz July 19, 2023 17:17
@bashonly bashonly merged commit 75dc8e6 into yt-dlp:master Jul 20, 2023
14 checks passed
@bashonly bashonly deleted the fix/legacy-server-connect branch December 7, 2023 15:13
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that is not site-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants