Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[networking] Fix --legacy-server-connect #7645

Merged
merged 1 commit into from
Jul 20, 2023

[networking] Fix `--legacy-server-connect`

f6508fd
Select commit
Failed to load commit list.
Merged

[networking] Fix --legacy-server-connect #7645

[networking] Fix `--legacy-server-connect`
f6508fd
Select commit
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Jul 19, 2023 in 19s

Analysis complete

Summary

Fix a typo in the legacy_server_connect option name for network requests. This option allows using older SSL/TLS protocols for compatibility with some servers. The typo was present in both the test file test/test_networking.py and the main file yt_dlp/YoutubeDL.py.

Walkthrough

  • Fix typo in legacy_server_connect option name (link, link)

Poem

legacy_server_connect
A typo in the code
Fixed in two places

Emoji

🐛🔧🧪

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 15.3 seconds
test/test_networking.py ✅ Finished 7.5 seconds
yt_dlp/YoutubeDL.py ✅ Finished 7.5 seconds