New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor] Add magentamusik.de #7790
Conversation
Do not change file or extractor class name. You can add an |
I created a new one, because the old page is offline. The URLs in the old file do not work anymore. They just redirect to a 404 page. magentamusik.de is a completely new page and replaces the old magenta-musik-360.de page. I don't see how it makes sense to keep the old extractor. I could replace the internals of the old one, and keep the name, if you want, tho. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, idk why I thought the URLs are still working. Maybe I accidentally tried with new URL instead? Or maybe it was when I made the comment and no longer is? Either way, ignore previous review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took so long for someone to take a proper look at this.
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
Authored by: pwaldhauer, seproDev Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
The old extractor for magenta-musik-360.de did not work anymore, because the page changed to magentamusik.de and its using HLS stuff now. So I created a new extractor.
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 6e6dbeb
Summary
🎵🕸️🇩🇪
Added a new extractor for MagentaMusik and renamed the existing extractor for MagentaMusik 360. This allows downloading videos from both platforms.
Walkthrough
magentamusik360.py
tomagentamusik.py
to avoid confusion with different platform (link, link)