Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor] Add magentamusik.de #7790

Merged
merged 5 commits into from Jan 18, 2024
Merged

[extractor] Add magentamusik.de #7790

merged 5 commits into from Jan 18, 2024

Conversation

pwaldhauer
Copy link
Contributor

@pwaldhauer pwaldhauer commented Aug 8, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

The old extractor for magenta-musik-360.de did not work anymore, because the page changed to magentamusik.de and its using HLS stuff now. So I created a new extractor.

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 6e6dbeb

Summary

🎵🕸️🇩🇪

Added a new extractor for MagentaMusik and renamed the existing extractor for MagentaMusik 360. This allows downloading videos from both platforms.

magentamusik.py
New extractor for music
Autumn of downloads

Walkthrough

  • Add a new extractor for MagentaMusik website (link)
  • Rename magentamusik360.py to magentamusik.py to avoid confusion with different platform (link, link)

@pukkandan
Copy link
Member

Do not change file or extractor class name. You can add an IE_NAME if desired. Also, the old URLs still seem to work on browser and so support should be kept. Don't remove the tests either. Just fix them and add new ones.

@pwaldhauer
Copy link
Contributor Author

Do not change file or extractor class name. You can add an IE_NAME if desired. Also, the old URLs still seem to work on browser and so support should be kept. Don't remove the tests either. Just fix them and add new ones.

I created a new one, because the old page is offline. The URLs in the old file do not work anymore. They just redirect to a 404 page. magentamusik.de is a completely new page and replaces the old magenta-musik-360.de page. I don't see how it makes sense to keep the old extractor. I could replace the internals of the old one, and keep the name, if you want, tho.

@bashonly bashonly added site-bug Issue with a specific website pending-fixes PR has had changes requested labels Aug 21, 2023
@bashonly

This comment was marked as outdated.

@bashonly bashonly added the stale-pr PR that has been pending fixes for a long time label Sep 16, 2023
@pukkandan pukkandan removed pending-fixes PR has had changes requested stale-pr PR that has been pending fixes for a long time labels Sep 21, 2023
@pukkandan
Copy link
Member

I created a new one, because the old page is offline.

Sorry, idk why I thought the URLs are still working. Maybe I accidentally tried with new URL instead? Or maybe it was when I made the comment and no longer is? Either way, ignore previous review

Copy link
Collaborator

@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long for someone to take a proper look at this.

yt_dlp/extractor/magentamusik.py Outdated Show resolved Hide resolved
yt_dlp/extractor/magentamusik.py Outdated Show resolved Hide resolved
yt_dlp/extractor/magentamusik.py Outdated Show resolved Hide resolved
yt_dlp/extractor/magentamusik.py Outdated Show resolved Hide resolved
yt_dlp/extractor/magentamusik.py Outdated Show resolved Hide resolved
yt_dlp/extractor/magentamusik.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label Nov 3, 2023
@seproDev seproDev added the stale-pr PR that has been pending fixes for a long time label Dec 5, 2023
@seproDev seproDev added pending-review PR needs a review site-request Request to support a new website and removed pending-fixes PR has had changes requested stale-pr PR that has been pending fixes for a long time site-bug Issue with a specific website labels Jan 14, 2024
yt_dlp/extractor/magentamusik.py Outdated Show resolved Hide resolved
yt_dlp/extractor/magentamusik.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-fixes PR has had changes requested and removed pending-review PR needs a review labels Jan 18, 2024
Co-Authored-By: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly removed the pending-fixes PR has had changes requested label Jan 18, 2024
@seproDev seproDev merged commit 5e2e24b into yt-dlp:master Jan 18, 2024
6 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Authored by: pwaldhauer, seproDev

Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants