Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie] Extract info from <media> elements in SMIL manifest #8504

Merged
merged 2 commits into from Nov 18, 2023

Conversation

seproDev
Copy link
Collaborator

@seproDev seproDev commented Nov 3, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Currently, the SMIL parser only extracts media streams from <audio> and <video> elements.
While as far as I can tell not spec compliant, in practice <media> elements are also sometimes used.
Looking around this seems to be something Microsoft likes to do, for example in Windows Media Player Playlists and Windows Media Services.

Needed for proper SMIL parsing in #7790

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at fe9b464

Summary

🎬🛠️🇳🇴

Add support for SMIL files with <media> tags in common.py. This fixes the extraction of some NRK TV videos.

<media> tag found
SMIL extraction improved
Winter of content

Walkthrough

  • Support SMIL files with <media> tags by extending the media element XPath (link)

@seproDev seproDev added the enhancement New feature or request label Nov 3, 2023
@bashonly bashonly self-requested a review November 3, 2023 04:02
@seproDev seproDev mentioned this pull request Nov 3, 2023
9 tasks
@Grub4K Grub4K self-requested a review November 3, 2023 13:44
yt_dlp/extractor/common.py Outdated Show resolved Hide resolved
Co-authored-by: Simon Sawicki <accounts@grub4k.xyz>
@bashonly bashonly self-assigned this Nov 16, 2023
@bashonly bashonly merged commit ddb2d75 into yt-dlp:master Nov 18, 2023
16 checks passed
@seproDev seproDev deleted the smil-media branch November 18, 2023 21:51
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants