New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract nhk world's new stream provider #8249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendship ended with piksel now stream.co.jp is my best friend - nhk, probably
bashonly
requested changes
Oct 3, 2023
Co-Authored-By: bashonly <bashonly@bashonly.com>
bashonly
approved these changes
Oct 3, 2023
IIRC videos from this site expire rather quickly, but can we extract old pre-9/26 videos from both piksel and the new API endpoint? |
the piksel APIs are gone apparently |
Grub4K
requested changes
Oct 5, 2023
Co-Authored-By: Simon Sawicki <contact@grub4k.xyz>
bashonly
requested changes
Oct 6, 2023
Grub4K
approved these changes
Oct 6, 2023
bashonly
approved these changes
Oct 6, 2023
11 tasks
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#8242 Authored by: garret1317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
friendship ended with piksel
now stream.co.jp is my best friend
- nhk, probably
I think it would be a good idea to cache the api url/token - they probably don't change at all
but grub4k said don't do that kind of thing in yt-dlp proper in the discord, so i won't
Fixes #8242
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 932e0a0
Summary
🇯🇵📺🛠️
Improve NHK video extraction by using a new method to get and parse stream data. Fix
Piksel
extractor issue.Walkthrough
_get_vod_api
, link)_extract_episode_info
, link)_extract_m3u8_formats_and_subtitles
, link)Piksel
extractor with the new approach (_extract_episode_info
, link)