-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NHK World vods in Japanese exhibit list index out of range error #8303
Comments
looks like the https://nwapi.nhk.jp/nhkworld/vodesdlist/v7b/episode/0046-268/ja/all/all.json (nothing there) seems the assumption is that ids will always be 7 characters, but the japanese news is 10 if len(episode_id) == 7:
episode_id = episode_id[:4] + '-' + episode_id[4:] it all starts working beautifully but |
wait no its only broken because it gets matched by the video regex lmao |
radio was getting matched by a section of the regex meant for the video extractor, and japanese-language vods broke because their ids were too long. this commit fixes NhkVodIE so it can extract japanese-language vods, by removing the explicit specification of the length of the ID. It also splits radio and tv into their own IEs, with separate regexes, so they don't conflict with each other. closes yt-dlp#8303 and fixes radio extraction
radio was getting matched by a section of the regex meant for the video extractor, and japanese-language vods broke because their ids were too long. this commit fixes NhkVodIE so it can extract japanese-language vods, by removing the explicit specification of the length of the ID. It also splits radio and tv into their own regexes so they don't conflict with each other. fixes yt-dlp#8303 and radio extraction, replaces yt-dlp#8305
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Closes #8303 Authored by: garret1317
❤️ |
Closes yt-dlp#8303 Authored by: garret1317
DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
Checklist
Region
From anywhere outside of Japan determined by request source IP address
Provide a description that is worded well enough to be understood
Per issue #8242 comment 1751738030:
Attempting to download
NhkVod
videos in Japanese athttps://www3.nhk.or.jp/nhkworld/ja/...
currently produces alist index out of range
error. English-language videos athttps://www3.nhk.or.jp/nhkworld/en/...
do not exhibit the same behavior, these are now working as of yesterday's merged pull request 8249 andyt-dlp
version2023.10.07
.For example daily noon and evening news videos in Japanese at https://www3.nhk.or.jp/nhkworld/ja/ondemand/video produce attached verbose output.
For context: these videos are intended for Japanese out of country so downloadable only outside of Japan. The site sends different HTTP response bodies depending on whether or not it perceives a request source IP address to be within Japan or outside of Japan. When outside of Japan the page shows:
By my understanding the videos highlighted with red border don't have any retention, NHK only ever offers the current day's video for download. These two examples are today's 7 pm news (ニュース7 aka nyusu 7) and noon news (正午のニュース aka shogo no nyusu).
"Within" Japan you'll get:
Basically asking you to use your NHK Plus account to watch a show you missed or to get yourself an NHK World Premium subscription.
Provide verbose output that clearly demonstrates the problem
yt-dlp -vU <your command line>
)'verbose': True
toYoutubeDL
params instead[debug] Command-line config
) and insert it belowComplete Verbose Output
The text was updated successfully, but these errors were encountered: