[core] Use lazy quantifier in regex for sanitizing dates in js_to_json

[awalgarg]

Given the following JavaScript code as string:

[new Date("foobar"), '("baz")']

The greedy quantifier's usage matches the string till the last quote instead of just the text inside the parenthesis. This patch fixes that using the STRING_RE regex for proper string literal matching.

Also updated tests.

Template

Before submitting a pull request make sure you have:

• At least skimmed through contributing guidelines including yt-dlp coding conventions
• Searched the bugtracker for similar pull requests
• Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

• I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

• Core bug fix/improvement

Copilot Summary

🤖 Generated by Copilot at c3dadad

Summary

🐛🕒🎬

Fix js_to_json bug with single-quoted strings in new Date arguments. This improves YouTube metadata extraction.

js_to_json fixed
Single quotes now accepted
Winter of errors

Walkthrough

• Fix bug in js_to_json function that caused parsing errors for single-quoted strings in new Date constructor (link)

[coletdjnz]

Also update/add tests if feasible (see test/test_utils.py - possibly test_js_to_json_edgecases).

[Grub4K]

We can instead use proper greedy string matching by doing this:

-        code = re.sub(r'new Date\((".+")\)', r'\g<1>', code)
+        code = re.sub(rf'new Date\(({STRING_RE})\)', r'\g<1>', code)

It passes the test you provided:

        on = js_to_json('[new Date("spam"), \'("eggs")\']')
        self.assertEqual(json.loads(on), ['spam', '("eggs")'], msg='Date regex should match a single string')

[awalgarg]

Thanks both, updated the PR. Using STRING_RE for matching string literals and updated tests.

[coletdjnz]

lgtm